search

synesthesiam / rhasspy

Rhasspy voice assistant for offline home automation
https://rhasspy.readthedocs.io
MIT License
942 stars 101 forks source link

Fix Rasa tag synonyms #183

Closed daniele-athome closed 4 years ago

daniele-athome commented 4 years ago

When using slots like this:

(playlist long name):PlaylistName

Used as:

($playlist){playlist}

It is converted to Rasa training format like this:

[playlist long name](playlist)

That results in resolving the entity incorrectly, as "playlist long name" instead of "PlaylistName". This patch fixes that by adding a synonym for Rasa:

  ## intent:...
  - [playlist long name](playlist:PlaylistName)
daniele-athome commented 4 years ago

I've found a problem in this approach, but I believe it's caused by another issue. When using spaces in tags ("playlist long name") the generated training data is weird:

[playlist long name long name](playlist long PlaylistName)

But this is probably something I'm doing wrong, right?

EDIT: if PlaylistName contains space too it gets worse :-(

daniele-athome commented 4 years ago

Hey! Thanks for working on this. Does d770679373d284a2ce23160d8c0d6b2e2961ad3f relates to this by any chance?

synesthesiam commented 4 years ago

Let's continue this work over in rhasspy-rasa-nlu-hermes

daniele-athome commented 4 years ago

I don't understand, should I open a new ticket in the other repository?

synesthesiam commented 4 years ago

Sorry, I wasn't clear. The plan is to split out the training/recognition part of rhasspy-rasa-nlu-hermes into a rhasspy-rasa-nlu module, which could then be referenced by Rhasspy 2.4/2.5 instead of being baked into 2.4 as it is now.

daniele-athome commented 4 years ago

Ok thanks. But I mean what about this bug then?