synesthesiam / voice2json

Command-line tools for speech and intent recognition on Linux
MIT License
1.09k stars 63 forks source link

Add Init parameter to docker run #19

Closed johanneskropf closed 4 years ago

johanneskropf commented 4 years ago

This should fix the problem with wait wake not beeing able to be stopped when run in docker. The init argument adds an init process to the container that forwards signals and reaps children on close. This should effectively prevent any processes getting orphaned and beeing left behind as zombies. Reference here: https://docs.docker.com/config/containers/multi-service_container/ https://github.com/krallin/tini

I also added /dev/shm but you can take that out 😉

synesthesiam commented 4 years ago

Excellent, thank you!