search

synewaves / rubillow

Ruby library to access the Zillow API
MIT License
50 stars 39 forks source link

Doesn't Return Rent Zestimate #3

Closed danielberkompas closed 11 years ago

danielberkompas commented 11 years ago

Zillow's api docs for GetZestimate indicate that you can get a RentZestimate by passing the rentzestimate: true option.

Rubillow works with this up to a point. When I added rentzestimate: true to the options in HomeValuation#zestimate like so...

Rubillow::HomeValuation.zestimate(zpid: zillow_property_id, rentzestimate: true)

...Zillow did respond with the RentZestimate. I can see it in the @parser variable of the resulting class. However, it didn't assign the values to a property that I can easily access.

Any chance this could be fixed? I'm willing to take a stab at it myself and open a pull request.

synewaves commented 11 years ago

This is definitely something that needs to be added. I'll check into it and see what can be done.

danielberkompas commented 11 years ago

@synewaves I have a pull request in the works, will be posting it shortly.

danielberkompas commented 11 years ago

@synewaves Any idea what is breaking the build on TravisCI? I can't really figure it out. Specs work fine on my local machine in 1.9.3, so not sure why it fails for 1.9.3 in TravisCI.

synewaves commented 11 years ago

I'm getting an error running specs on my end, but it's unrelated to these commits. I'm getting an error with the RSpec custom matcher (failure_message is undefined). I can fix that error in the test and everything runs fine. I am going to commit this change in master. We'll see if that fixes the Travis build.

synewaves commented 11 years ago

@danielberkompas my current master passes on all versions in Travis now.

danielberkompas commented 11 years ago

@synewaves My changes are now passing. Any thoughts?

synewaves commented 11 years ago

Looks good. I'll pull this in.