search

synfig / synfig

This is the Official source code repository of the Synfig project
https://synfig.org
GNU General Public License v3.0
1.85k stars 330 forks source link

Dark theme by default? #1041

Open morevnaproject opened 4 years ago

morevnaproject commented 4 years ago

People love dark theme. People find it looking cool. Dark theme is used by default in many graphic apps. It is better for eyes.

So, how about to make dark theme enabled by default in 1.4.0? ^__^

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/85193850-dark-theme-by-default?utm_campaign=plugin&utm_content=tracker%2F321991&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F321991&utm_medium=issues&utm_source=github).
rodolforg commented 4 years ago

Some icons don't have enough contrast in dark mode, I think.

Like that one for swap background - outline colors.

ebarranco commented 4 years ago

Yeah, Dark theme no questions asked, but definitely for some icons its readability could be better. Screenshot_20191210_163835

BobSynfig commented 4 years ago

Why not to let the choice to the user during first startup? Lots of apps and IDE do it ;)

ankit-kumar-dwivedi commented 4 years ago

Also we can provide better contrast for icons not visible in the dark mode. This has to be done someday anyway.

On Fri, Dec 13, 2019, 12:28 AM BobSynfig notifications@github.com wrote:

Why not to let the choice to the user during first startup? Lots of apps and IDE do it ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/synfig/synfig/issues/1041?email_source=notifications&email_token=AI7ACH4QYX6LRQZSLGJRFS3QYKCUPA5CNFSM4JYZ4AC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXVENY#issuecomment-565137975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7ACH4L5GWZUAEN3UI4OBTQYKCUPANCNFSM4JYZ4ACQ .

morevnaproject commented 4 years ago

Why not to let the choice to the user during first startup?

I think this will be too much. ^__^ I remember Krita, AfterEffects, Photoshop, DarkTable doing that by default without asking.

Some icons don't have enough contrast in dark mode

True. Let's identify which ones and fix. We can add bright outline for example.

libreartist commented 4 years ago

Hi! I just experimented with the existing Synfig icons, and attempted to create uniformity among them (sorry, lots of Synfig icons belong to different styles). I'm presenting, what I did so far.

Sample svg

Icons are matched against different UI colours. I didn't think any different. I tried to match the new set of icons to match form and colours of existing icons. Along with customising the icons for darker UI, I think it's the right time to touch upon the icons as well.

If Synfig needs a whole new effort for the icons, I want to present the icons (with UI) some of the other apps (just for reference).

OpenToonz: UI_1

Affinity Photo: affinity-photo-ss PNG 37d7c35e0f5aff0deeb3220c2bfda893

These are just references that I love. If wanted, I would like to work on the icons in any of the ways the community expects.

With regards, Benificiary of Synfig

libreartist commented 4 years ago

Adding to the above, Regarding the icons I did, these are random pick, to see how to bring style uniformity to differently-styled icons. I removed gradients and some of the details, and tweaked them a bit, for the sake of uniformity. If time permits, even the gradients and some details can be added to make them even richer. Also, I tried to follow the tango icons colour palette. If any different colour palette has to be used, advise me on that as well.

rodolforg commented 4 years ago

@libreartist Fantastic! I intend to (propose to) change the checkbox for layer visibility in Layer tree dock to an more intuitive icon - and maybe provide another icon for render-enable/disable too instead of itallic. Pretty much like Blender 2.80. If @morevnaproject aproves this changes, could you please provide those icons?

libreartist commented 4 years ago

Sure.

morevnaproject commented 4 years ago

Hi! Apologies for delay, I have missed this conversation somehow...

@libreartist I absolutely love what you did and appreciate your contributions here.

The only thing that made me feel weird are icons of humans, that remind me icons on traphic light, but with opposite coloring ^__^"

screenshot_008

I intend to (propose to) change the checkbox for layer visibility in Layer tree dock to an more intuitive icon - and maybe provide another icon for render-enable/disable too instead of itallic. Pretty much like Blender 2.80.

That would be great!

Thanks again!

rodolforg commented 4 years ago

@libreartist , as Konstantin approved, could you please provide us icons for these flags:

I'd appreciate it a lot :)

morevnaproject commented 4 years ago

layer selection locking (locked / unlocked)

Just a note:

Layer Selection Locking is actually a Layer Parameter (which means it can be animated). Other flags you mentioned are not Layer Parameters (they cannot be animated and thus have influence on whole timeline).

Actually, we can make Layer Selection Locking behave as Layer visibility flags - i.e. not a Layer Parameter and non-animatable.

What people think about this idea? Does anyone animates Layer Selection Locking and finds that useful?

rodolforg commented 4 years ago

@libreartist ping ? :)

libreartist commented 4 years ago

Hi, sorry, I couldn't respond, since I have to relocate, in relation to the recent lockdown situation. Hope, everyone is safe out there. My prayers. I could see that @Agnyy is doing a lot well with the icons over there at #1458. Thank you @morevnaproject @rodolforg for responding.