synfinatic / aws-sso-cli

A powerful tool for using AWS Identity Center for the CLI and web console.
https://synfinatic.github.io/aws-sso-cli/
GNU General Public License v3.0
413 stars 49 forks source link

switch AWS_SSO_SESSION_EXPIRATION to RFC3339 #870

Closed synfinatic closed 1 month ago

synfinatic commented 1 month ago

Fixes: #837

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.13%. Comparing base (fbee93d) to head (8eae16e). Report is 40 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870/graphs/tree.svg?width=650&height=150&src=pr&token=F8454GS4HS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner)](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) ```diff @@ Coverage Diff @@ ## main #870 +/- ## ========================================== - Coverage 80.32% 80.13% -0.19% ========================================== Files 37 38 +1 Lines 3405 3427 +22 ========================================== + Hits 2735 2746 +11 - Misses 595 606 +11 Partials 75 75 ``` | [Flag](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | `80.13% <88.89%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | Coverage Δ | | |---|---|---| | [internal/ecs/http.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?src=pr&el=tree&filepath=internal%2Fecs%2Fhttp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvZWNzL2h0dHAuZ28=) | `100.00% <100.00%> (ø)` | | | [internal/storage/storage.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?src=pr&el=tree&filepath=internal%2Fstorage%2Fstorage.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvc3RvcmFnZS9zdG9yYWdlLmdv) | `94.23% <87.50%> (-0.21%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner). Last update [fb95df2...8eae16e](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/870?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner).