Closed synfinatic closed 3 months ago
Attention: Patch coverage is 92.30769% with 8 lines in your changes missing coverage. Please review.
92.30769%
8 lines
Project coverage is 83.64%. Comparing base (8363d9d) to head (0693c6a).
8363d9d
0693c6a
Codecov Report
Attention: Patch coverage is
92.30769%
with8 lines
in your changes missing coverage. Please review.Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925/graphs/tree.svg?width=650&height=150&src=pr&token=F8454GS4HS&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner)](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) ```diff @@ Coverage Diff @@ ## main #925 +/- ## ========================================== + Coverage 83.40% 83.64% +0.24% ========================================== Files 40 40 Lines 2843 2934 +91 ========================================== + Hits 2371 2454 +83 - Misses 384 388 +4 - Partials 88 92 +4 ``` | [Flag](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | `83.64% <92.31%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) | Coverage Δ | | |---|---|---| | [internal/storage/json\_store.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&filepath=internal%2Fstorage%2Fjson_store.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvc3RvcmFnZS9qc29uX3N0b3JlLmdv) | `95.45% <100.00%> (+0.89%)` | :arrow_up: | | [internal/storage/keyring.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&filepath=internal%2Fstorage%2Fkeyring.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvc3RvcmFnZS9rZXlyaW5nLmdv) | `92.67% <100.00%> (+0.62%)` | :arrow_up: | | [internal/storage/storage.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&filepath=internal%2Fstorage%2Fstorage.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvc3RvcmFnZS9zdG9yYWdlLmdv) | `96.30% <100.00%> (+1.06%)` | :arrow_up: | | [internal/ecs/client/client.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&filepath=internal%2Fecs%2Fclient%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvZWNzL2NsaWVudC9jbGllbnQuZ28=) | `92.16% <93.94%> (-0.34%)` | :arrow_down: | | [internal/ecs/server/server.go](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?src=pr&el=tree&filepath=internal%2Fecs%2Fserver%2Fserver.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner#diff-aW50ZXJuYWwvZWNzL3NlcnZlci9zZXJ2ZXIuZ28=) | `92.68% <73.91%> (-7.32%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/synfinatic/aws-sso-cli/pull/925?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Aaron+Turner) > `Δ = absolute