search

synfinatic / udp-proxy-2020

A crappy UDP router for the year 2020 and beyond
MIT License
106 stars 7 forks source link

rename --listen and --promisc #12

Closed synfinatic closed 4 years ago

synfinatic commented 4 years ago

The existing flags are probably confusing for non-technical people. In reality, they're more about what kind of interface you're using so it would be more like --ethernet and --loopback

ilmanzo commented 4 years ago

Hello, glad to contribute! Can I take this issue ?

synfinatic commented 4 years ago

So I've realized that this is something that should be fixed along with #5. Basically use the Flags in https://golang.org/pkg/net/#Interface to auto-detect if the interface supports broadcasts or not, so the goal would to have a single --interface flag and handle things automatically.

FWIW, this is probably the next thing I was going to work on (once I'm done refactoring & cleaning up the Makefile/Dockerfiles) because this and #5 are blocking #6.

So yeah, if you want to send a PR that's great.

ilmanzo commented 4 years ago

Ok I'll give it a try :)