search

synfinatic / udp-proxy-2020

A crappy UDP router for the year 2020 and beyond
MIT License
103 stars 7 forks source link

New Logger #140

Closed jrc2139 closed 9 months ago

jrc2139 commented 9 months ago

This is an option to move from the maintenance mainted logrus to the zero dependency phuslu/log package.

jrc2139 commented 9 months ago

i have a few more branches based on this PR in https://github.com/jrc2139/udp-proxy-2020

one is for adding a pprof server for getting traces one is to update to latest go so we can do PGO builds one is a refactor to move all non main.go files to the idiomatic internal directory. it's supposed to be better for the compiler to do this. i also managed to do a freebsd14 x64 build successfully for vagrant, but am unable to do it for arm and arm64, so hesistant to post it

synfinatic commented 9 months ago

Uhm, I'm not sure what to do with this. I definitely wasn't prioritizing changing the logger (although I won't argue it shouldn't be changed), and I wasn't really considering switching to phuslu/log as there are other more popular options like zap and of course Go 1.21 introduced log/slog.

Perhaps you'd like to explain why udp-proxy-2020 should switch to phuslu/log vs. the alternatives? I get that it's fast, but performance isn't the top priority (or even 2nd) to me.

That said, in general I get different projects have different criteria for accepting PR's, I'd just say for big changes like this I'd recommend reaching out to the developers first by opening a ticket and describing the change.

jrc2139 commented 9 months ago

Okay no worries. Just sharing what I was working on 👍