search

synhershko / NAppUpdate

A simple framework for providing auto-update support to .NET applications
http://www.code972.com/blog/2010/08/nappupdate-application-auto-update-framework-for-dotnet/
Apache License 2.0
525 stars 163 forks source link

Implemented FtpSource based on FluentFtp library #126

Open PurpleGray opened 6 years ago

PurpleGray commented 6 years ago

Hello, in my project I've been using your library, but my requirement was to update from ftp. So I've added new type of source, so created this pull request. May be it can be useful for someone.

synhershko commented 6 years ago

Great, thanks! Any reason you are using FluentFTP and not the CLR's classes ? We would like to keep this library without dependencies

See https://msdn.microsoft.com/en-us/library/system.net.ftpwebrequest.aspx

PurpleGray commented 6 years ago

Ohh, you're right, I've been thinking about it, but just for time economy decided to use FluentFTP. I will rewrite it to CLR :)

PurpleGray commented 6 years ago

Ok, moved from FluentFTP to CLR

synhershko commented 6 years ago

Thanks, looks good! Any chance you can add tests for this new Source class?

PurpleGray commented 6 years ago

Yep, I'll do it in this week

PurpleGray commented 6 years ago

Hm, but how can I test ftp source? I found only approach like this: https://dougrathbone.com/blog/2012/09/26/integration-testing-ftp-connections-in-net Is it acceptable way to do it?