search

synhershko / Spatial4n

A Geospatial Library for .NET - a .NET port of spatial4j
Apache License 2.0
64 stars 24 forks source link

Completed work on the "context" tests, now the whole Java test suite is ported #2

Closed mattwarren closed 12 years ago

mattwarren commented 12 years ago

Can you take a look at the changes I had to make for the TestSystemPropertyLookup() test in SpatialContextFactoryTest.cs. I had to make some changes to the code the make the subclassing work, see https://github.com/mattwarren/Spatial4n/commit/3ae88f59410ca344701c2b5589b37bf9a14cd79f#L2L44.

Also did you see my msg here https://github.com/synhershko/Spatial4n/pull/1#issuecomment-5414180. It's about an issue I found with the Distance tests?

synhershko commented 12 years ago

Looks good, but basically that test should be testing loading the right Distance thing from system properties - app.config in the .NET is the right equivalent