synman / Octoprint-Bettergrblsupport

Better Grbl Support Plugin for Octoprint based (loosely) on the original Grbl Support plugin developed by mic159
https://github.com/synman/Octoprint-Bettergrblsupport/wiki
64 stars 19 forks source link

Missing Option 112 - Maximum Z Feed Rate on Ocotoprint Plugin Installation #82

Closed phalix closed 1 year ago

phalix commented 2 years ago

Traceback (most recent call last): File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/server/api/init.py", line 158, in pluginCommand response = api_plugin.on_api_command(command, data) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint/util/init.py", line 1737, in wrapper return f(*args, **kwargs) File "/home/pi/oprint/lib/python3.7/site-packages/octoprint_bettergrblsupport/init.py", line 1412, in on_api_command zf = int(float(self.grblSettings.get(112)[0]))

I found then, that in the Config.yaml of octoprint, the 112 is not in the grblsettingstext.

The issue is fixed when manually editing the config yaml in the octoprint folder.

synman commented 1 year ago

I sense I may be taking this on soon as I have a GRBL ESP32 machine I'm in the process of bringing online. The reason why it is failing is because the official version of GRBL doesn't have a $113 setting (the settings array is base 0 so 112 internally is actually $113):

https://github.com/gnea/grbl/blob/master/doc/markdown/settings.md