search

synml / SamFirm-continued

SamFirm extension support project.
MIT License
55 stars 13 forks source link

IMPROVEMENT - Change output firmware file name #3

Closed bovirus closed 4 years ago

bovirus commented 4 years ago

@LulinPollux

I propose you to change the default scheme for firmware file saving

Currently ex. for Samsung S10 Plus - SM-G975F (ITV) the info about firmware are

SamFirm v1.3.0 Checking firmware for SM-G975F/ITV/G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG Model: SM-G975F Version: G975FXXS3ASJG/G975FOXM3ASJD/G975FXXS3ASJA/G975FXXS3ASJG OS: Pie(Android 9) Filename: SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4 Size: 5340507952 bytes LogicValue: nx5habv1lq8u7e0n

and the output file name is

SM-G975F_1_20191028103127_vseyqod81a_fac.zip.enc4

My proposal is to chnage it to a scheme like

Samsung_DeviceName_CountryCode_Date(YYYY.MM.DD)_IDComponents

Ex.

Samsung_SM-G975F_ITV_20191028_975FXXS3ASJG-G975FOXM3ASJD-G975FXXS3ASJA-G975FXXS3ASJG.zip

What do you think about it?

In this way is clear in teh file the info about

Device Name Country Code Release Date Components version

Thanks.

synml commented 4 years ago

Hello. Thank you for giving me the improvement. I will update the program as you proposed. Ex: SM-G965N_KOO_20191021_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

Thanks.

synml commented 4 years ago

I updated the program to version 1.4.0. https://github.com/LulinPollux/SamFirm-continued/releases

bovirus commented 4 years ago

@LulinPollux Thanks for teh update.

After the use I believe that in teh output file name could be better to have as main info after the model name the firmware reelase date (and then after Country code).

SM-G965N_20191021_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

What do you think about it?

synml commented 4 years ago

I think it seems to be better too. I updated the program to version 1.4.1. https://github.com/LulinPollux/SamFirm-continued/releases

bovirus commented 4 years ago

Thank for new version 1.4.1. @LulinPollux

Please consder to improve it (when you can - is not necessary now just for this) as

SM-G965N_2019.10.21_KOO_G965NKSU2CSJ1-G965NOKR2CSJ1-G965NKOU2CSI1-G965NKSU2CSJ1.zip

Change Releaase date in file name from YYYYMMDD to YYYY..MM.DD

What do you think about it?

synml commented 4 years ago

I don't recommend that. Because if there is a dot in the file name, there can be problems that can be misrecognize as an extension. So most of them use YYYYMMDD format a lot.

bovirus commented 4 years ago

@LulinPollux

Right. Thanks.