synnada-ai / mithril

Mithril: A Modular Machine Learning Library for Model Composability
Apache License 2.0
31 stars 8 forks source link

fix: Fix ambiguous behavior of `extend` while adding a submodel #26

Closed kberat-synnada closed 1 week ago

kberat-synnada commented 1 week ago

Closes #20

Description

Bug of extend fixed.

What is Changed

Ambiguity of model extension without calling submodel and calling submodel with no arguments bug fixed by calling submodel with no arguments in the beginning of extend if directly model is given.

Checklist:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.91%. Comparing base (39e3eb0) to head (3022b78). Report is 4 commits behind head on main.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   85.90%   85.91%           
=======================================
  Files          61       61           
  Lines       15249    15251    +2     
=======================================
+ Hits        13100    13103    +3     
+ Misses       2149     2148    -1     
Files with missing lines Coverage Δ
mithril/framework/logical/model.py 96.22% <100.00%> (+0.01%) :arrow_up:

... and 1 file with indirect coverage changes


🚨 Try these New Features: