search

synolia / SyliusGDPRPlugin

Make your Sylius project GDPR compliant.
European Union Public License 1.2
18 stars 8 forks source link

Allow Sylius 1.11 #35

Closed adpeyre closed 2 years ago

adpeyre commented 2 years ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Fixed issue #...

Hi,

I'v tested this plugin on Sylius 1.11 and PHP 8.1. It works ;) You can allow this Sylius version.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

adpeyre commented 2 years ago

@oallain Can you merge it and create a tag ? I would like to use this plugin on my current project. :)

oallain commented 2 years ago

Can you add test in GitHub action? See https://github.com/synolia/SyliusGDPRPlugin/blob/master/.github/workflows/ci.yaml

adpeyre commented 2 years ago

Np @oallain Is it ok for you ? Arf no, I need to adjust tests again.

adpeyre commented 2 years ago

@oallain Can you launch tests again ?

adpeyre commented 2 years ago

@oallain I think, there is a problem with your tests (Phpstan or missing lib).

GalloisLuca commented 2 years ago

@adpeyre The problem doesn't come from our dev tools, the bundle zend has been abandonned and replace by this one laminas.

Can you in the file Synolia\SyliusGDPRPlugin\Processor\AdvancedActions\CompositeAdvancedActionsFormDataProcessor replace the use

use Zend\Stdlib\PriorityQueue;

By

use Laminas\Stdlib\PriorityQueue;

Plz, i think it will work properly

adpeyre commented 2 years ago

@GalloisLuca Done ! ;)

GalloisLuca commented 2 years ago

@adpeyre I'm going to close this PR, i've open an other one with your commits to make this work with all versions.

Thank you for your contribution !