synolia / oroneo

Other
11 stars 5 forks source link

Assets collection attribute type management (Akeneo EE) #4

Closed gplanchat closed 7 years ago

gplanchat commented 7 years ago

There is no management for the pim_assets_collection attribute type in the connector.

This attribute type is only present in the EE of Akeneo

Rmnndr commented 7 years ago

Thanks for your feedback. We've also seen your PR about this issue. We now must spend a quick time to analyze the code you suggest to merge it or not.

Notice that, even if this bundlle must be extendable, we don't plan to manage Enterprise features in this public version of the conncector.

gplanchat commented 7 years ago

Indeed, you don't want to support the EE features, I can understand this fact

I made the pr #8 to make possible to easily extend the bundle without rewriting too much code

Rmnndr commented 7 years ago

We saw it, thank you.

As noticed on an other issue, we must plan time really quickly to analyze all the suggested contributions.

Djamy commented 7 years ago

Thanks @gplanchat for your PR #8 that would permit to handle the mapping in an easier way.