synonymdev / bitkit

Self-custodial Bitcoin and Lightning Wallet for Android and iOS.
https://bitkit.to
MIT License
117 stars 22 forks source link

[Bug]: Android: QR button on Add Contact page takes multiple attempts to invoke #1635

Open catch-21 opened 6 months ago

catch-21 commented 6 months ago

Describe the bug

The QR button on the Add Contract page doesn't open the camera on first tap, it takes a few attempts.

Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots / Recording

https://github.com/synonymdev/bitkit/assets/74595920/2af5b284-c617-4db4-8c58-1c5b4a4a2663

Operating system

Android 13 TKQ1.220829.002

Bitkit version

v1.0.0-beta.113

Log output

No response

catch-21 commented 5 months ago

Tested on 6c75bd068c9bac72cc488c52e78f3ef7bba8a4ba Unfortunately, the hit area increase haven't resolved this. It still can take a few attempts for the scan button to register and open the camera, same as before.

https://github.com/synonymdev/bitkit/assets/74595920/94f73ac5-f1d6-4fd5-a322-82d5534c2b5b

https://github.com/synonymdev/bitkit/assets/74595920/555d66e0-eb7b-4c06-8327-f6e0d56d8d3d

https://github.com/synonymdev/bitkit/assets/74595920/29a273a7-2849-4700-9834-1c7d1962805e

coreyphillips commented 5 months ago

I'm not able to reproduce this issue in the Android emulator, iOS simulator, or on a physical device (Pixel 6 Pro). It might be that only certain devices are impacted.

We could try increasing the padding on the left of the camera button like so to help with devices that run into this:

Screenshot 2024-05-31 at 12 51 58 PM

Uploading screen-20240601-085847.mp4…

catch-21 commented 5 months ago

I am using a Poco F3 but I also get it on my emulated Pixel 3a. Using a mouse, I can more accurately attempt to click this QR icon and it seems that if I'm not hitting one of the orange corners then it is not registering, e.g. in the middle or between one of the four orange corners.

catch-21 commented 4 months ago

Verified in v127 9855fe5 I think it is better, not perfect because it invokes my keyboard still but not worth dwelling on.

JeanlChristophe commented 2 months ago

https://github.com/synonymdev/bitkit/issues/2157