synonymdev / bitkit

Self-custodial Bitcoin and Lightning Wallet for Android and iOS.
https://bitkit.to
MIT License
117 stars 22 forks source link

[Feature]: LN manual channel with external node #1972

Closed pwltr closed 1 month ago

pwltr commented 5 months ago

Describe the problem

Blocked by https://github.com/synonymdev/react-native-ldk/issues/30

While Bitkit does support LNURL-channel, there is no way to connect to nodes that do not generate such a QR.

Describe the solution

Add the flow for adding non Blocktank nodes. Also need to make sure open/close transactions are marked as such in the activity.

image

JeanlChristophe commented 3 months ago

jay will do https://github.com/synonymdev/react-native-ldk/issues/30. it will be available for August. only one day of work.

JeanlChristophe commented 2 months ago

https://github.com/synonymdev/react-native-ldk/pull/268

catch-21 commented 1 month ago

Tested on 1.0.5 (136)

1. We should allow those in US/Canada to use this feature: https://github.com/synonymdev/bitkit/issues/2252

2. Crash on iPhone if 'Continue' is pressed without entering any node details in on Manual Setup screen. This then may have broken my LDK node, or coincidentally this occurred. https://github.com/synonymdev/bitkit/issues/2253

3. Error shown without message on android in same scenario as above (2). Not raised a new issue but added observation here https://github.com/synonymdev/bitkit/issues/2253#issuecomment-2381871931. A fix must be tested on both platforms.

4. Host and Port are not required to proceed to attempt swipe and transfer, only the Node ID is. Form validation could be improved here for mandatory fields https://github.com/synonymdev/bitkit/issues/2257

5. Unable to establish a connection with Regtest Blocktank https://github.com/synonymdev/bitkit/issues/2259