synonymdev / bitkit

Self-custodial Bitcoin and Lightning Wallet for Android and iOS.
https://bitkit.to
MIT License
114 stars 24 forks source link

Local notification to open Bitkit #2094

Closed JeanlChristophe closed 1 week ago

JeanlChristophe commented 1 month ago

Description

When a user makes a request to open a channel, the user must come back to the app in between the time the channel is ready to be opened and before channel expiry. However, since the transaction can take several hours or even several days some users may forget and miss the time window, ending up with an expired channel order.

The problem is that the BT order is only valid for 2 days. We therefore need to warn the user to open Bitkit.

Ex: https://synonymworkspace.slack.com/archives/C0726U60V6Y/p1721769530317439

Solution Schedule local notifications telling the user that he must open Bitkit in order to continue the channel opening process.

Note: We don't check if the channel purchase transaction actually got confirmed (will be solved with wakeToOpen), so there can be the case where fees are spiking and the transaction doesn't confirm before order expiry. In this case the notifications will still (falsely) appear.

aldertnl commented 1 month ago

image

JeanlChristophe commented 1 month ago

First: after 24h Second: After 40h

pwltr commented 3 weeks ago

Updated description to better explain the problem and implementation

JeanlChristophe commented 1 week ago

I received a notification 24h after on my phone. But Once I clicked on it, nothing happened. I needed to open myself Bitkit.

pwltr commented 1 week ago

The changes from the stealth mode feature did break this on Android. If we end up reverting that feature this will be resolved.

JeanlChristophe commented 1 week ago

Yes, during the dev call Johna said we were killing this feature, right?