search

synonymdev / bitkit

Self-custodial Bitcoin and Lightning Wallet for Android and iOS.
https://bitkit.to
MIT License
118 stars 21 forks source link

[Bug]: 'Received' activity list item doesn't update expected time to confirm after boost #2100

Open catch-21 opened 4 months ago

catch-21 commented 4 months ago

Describe the bug

The receiving wallet doesn't update the estimated time for onchain activity to confirm when that transaction is boosted CPFP.

Reproduce

  1. Send onchain tx from wallet A to wallet B with lower than 'low' market fee rate
  2. Received activity list item on wallet B shows 'Confirming in 2 hours'
  3. Boost tranasction on wallet A so that it is expected in next block
  4. Received activity item on wallet B doesn't update to show new estimated confirmation time, even after manual refresh.

Screenshots / Recording

Operating system

Android 13 TKQ1.221114.001

Bitkit version

v130 d8f96e7d6475d2eef04ae08f9d9dd2c8894a8218

Log output

No response

pwltr commented 4 months ago

This is not easily done because currently the receiver doesn't know that the transaction has been CPFP'd. From the sender side the CPFP is just a self-send spending the (change) output from the ancestor. We can probably introduce some logic to watch all received transactions specifically for CPFP in the future but with since we're already running into issues with too many electrum requests this needs to be tested thouroughly.