search

synonymdev / bitkit

Self-custodial Bitcoin and Lightning Wallet for Android and iOS.
https://bitkit.to
MIT License
116 stars 23 forks source link

[Bug]: Advanced Manual Setup infinite button spinner on failure #2258

Closed catch-21 closed 3 weeks ago

catch-21 commented 3 weeks ago

Describe the bug

When invalid configuration is entered into the Manual Setup screen for LN connection, it is not possible to retry due to the button being disabled with a spinner shown indefinitely.

Reproduce

  1. Go to Advanced settings -> Lightning Connections -> Add Connection
  2. Input invalid node details
  3. Tap Continue
  4. Toast error is displayed indicating failure and the button shows a spinner animation that does not go away, this means it is not possible to correct the error in the form and tap again. Must navigate back and forth to retry.

Screenshots / Recording

https://github.com/user-attachments/assets/e3977f19-3b47-4eb3-867a-16f05dc123ac

Operating system

Android 14

Bitkit version

1.0.5 (136)

Log output

No response

catch-21 commented 2 weeks ago

Verified on 0d67faa2509b1ec083d475abc80e90802f8d7d28 Now there is no spinner, the button shows it has been tapper for a few seconds whilst it determines whether the details are usable. A spinner would be better to indicate processing but this is acceptable.