Fix TDynArray find with external index on small array

[serhyklim]

Sorry, if I misunderstood something (just at the beginning with this beautiful framework), but I believe there is an error in TDynArray.Find(with external index) on a small array. For brute force branch array length decremented incorrectly, so last item never compared and can not be found (unless only 1 item in array, then any searched item in array)

Test:

var A, Aidx: TIntegerDynArray; DA: TDynArray; i: integer; begin DA.Init(TypeInfo(TIntegerDynArray), A); i := 1; DA.Add(i); DA.CreateOrderedIndex(Aidx,SortDynArrayInteger); i := 2; Check(DA.Find(i, Aidx, SortDynArrayInteger)=-1); // fail, 2 in [1,] DA.Add(i); DA.CreateOrderedIndexAfterAdd(Aidx, SortDynArrayInteger); Check(DA.Find(i, Aidx, SortDynArrayInteger)>=0); // fail, 2 not in [1,2,] end;

[synopse]

Please try https://github.com/synopse/mORMot2/commit/10577179

[serhyklim]

On Mon, Jun 5, 2023 at 11:25 AM ab @.***> wrote:

Please try 10577179 https://github.com/synopse/mORMot2/commit/10577179

Thank you! But, maybe a comparison >= n (Line 7803) is somewhat error-prone (better will be strict =)? When Length(index) > GetCount, index is unsynced (probably, after delete, index not updated). Search by index in that case can retrieve index of deleted item (or point incorrectly after items move)?

Message ID: @.***>