synopse / mORMot2

OpenSource RESTful ORM/SOA/MVC Framework for Delphi and FreePascal
https://synopse.info
Other
485 stars 122 forks source link

Not all tests passed #252

Closed lbcsy closed 1 month ago

lbcsy commented 1 month ago

Start to look into mORMot 2, run tests first and got 4 failures:

synopse commented 1 month ago

Which compiler do you use? Which version of the source code and statics are you using? On which operating system are you running it? On which computer are your running it? Do you have access to an unrestricted/unproxied Internet connection? What is the log content? Can you debug a little and report which actual Check() failed?

The automated tests are currently passing: https://luti.tranquil.it/history/tis-test-mormot2 So I guess this is due to some specificity on your system.

Please use the forum for such discussion. Closing this issue here because it is not reproducible.

lbcsy commented 1 month ago

It seems the SID tests do not cover the case where user is created and linked to Azure Acitve Directory, i.e., my user's SID starts with 'S-1-12-1-', thus below checking in the test failed: CurrentRawSid(s1, wttProcess); CurrentRawSid(s2, wttThread); Check(SidCompare(pointer(s1), pointer(s2)) = 0); s := RawSidToText(s1); CheckUtf8(IdemPChar(pointer(s), 'S-1-5-'), s); // domain users are S-1-5-21-*, but LOCAL_SYSTEM is S-1-5-18