synox / disposable-mailbox

self-hosted disposable email service (php) using catch-all and imap
GNU General Public License v3.0
390 stars 147 forks source link

Postbox having '+' sign in address doesn't work #72

Open Magomogo opened 5 years ago

Magomogo commented 5 years ago

Example: foo+bar@host.name

Link parameters in the frontend.template.php should be encoded using rawurlencode function.

- &address=$user->address
+ &address=rawurlencode($user->address)
synox commented 5 years ago

can not reproduce, works for me. I can receive and display messages.

Please provide more information.

synox commented 5 years ago

c2e0bb78-31da-4597-902b-d2352a409049

Magomogo commented 5 years ago

Yes, you can see the messages, but can't manipulate.

  1. New emails won't appear without page reload
  2. Click on "delete" button causes an error.
Magomogo commented 5 years ago

@synox could you reproduce?

synox commented 5 years ago

No time at the moment. Can you provide a PR?

Magomogo commented 5 years ago

No time as well :(

Spegeli commented 5 years ago

Can confirm this issue. In the frontend.template.php we need to rawurlencode the user adress and inside the router.php to rawurldecode. Otherwise we get issues on email adresses which contains a + or - (when download or delete them).