search

synqs / coquma-sim-spooler

The Unlicense
0 stars 0 forks source link

Get started on making the spooler more robust #6

Closed fretchen closed 2 years ago

fretchen commented 2 years ago

I do not see a good way around this if we want to stabilize our code ...

fretchen commented 2 years ago

I got started, but I personally expect this to be a rather painful road with plenty of other little commits that we have to get into the main code before this works :(

What do you think @RohitPrasadBhatt ?

fretchen commented 2 years ago

Please feel free to merge, when you think that it is fine. I will from now on work off this branch ...

RohitPrasadBhatt commented 2 years ago

I see that the pylint changed the name of the folder to beginning in small case (spooler_files). This will break scp.yml workflow because it looks for a folder (Spooler_files) and copies that to Mannheim. So we should update scp.yml file and use small case.

Here: https://github.com/synqs/coquma-sim-spooler/blob/pylint-actions/.github/workflows/scp.yml#L20

fretchen commented 2 years ago

This should fix this issue too. Feel free to push it @RohitPrasadBhatt .

RohitPrasadBhatt commented 2 years ago

LGTM!