search

synrc / rt

☀ RT: Erlang Runtime Library
https://rt.n2o.dev
ISC License
8 stars 4 forks source link

[disk_log.erl] multi_req/2 weird return value #4

Open tank-bohr opened 5 years ago

tank-bohr commented 5 years ago

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/disk_log.erl#L1876-L1884

Reply isn't accumulated in foldl. Thus ok is returned if there were any successful req

5HT commented 5 years ago

I would say more general: we need to ban recieve end constructions in anything but gen_server replacement. The disk_log as the core transactional chain for mnesia and other services could be replaced by more modern https://github.com/xio/replayq implementation or at least merged with some ideas.