synsense / sinabs

A deep learning library for spiking neural networks which is based on PyTorch, focuses on fast training and supports inference on neuromorphic hardware.
https://sinabs.readthedocs.io
GNU Affero General Public License v3.0
81 stars 8 forks source link

Merge sinabs-dynapcnn to sinabs #198

Closed ssinhaleite closed 10 months ago

ssinhaleite commented 11 months ago

Currently, the sinabs-dynapcnn project is hosted separately. However they are highly related, and to reduce maintenance costs, we will merge them.

Merge the projects will be considered complete when:

a new release of sinabs will be generated, possibly causing breaking/incompatibility changes: v2.0.0

bauerfe commented 10 months ago

I went through all the tests. There were no real redundancies. However, I added a few sub-folders to organize everything a bit, and merged two files that were testing the same class.

Something that we should take a look at: I also ran the tests that are marked as skip and some of them fail:

FAILED test_dynapcnn/test_device_movement.py::test_multi_device_movement - KeyError: 'speck2b:0'
FAILED test_dynapcnn/test_discover_device.py::test_list_all_devices - AttributeError: module 'sinabs.backend.dynapcnn.io' has no attribute 'get_all_samna_devices'
FAILED test_dynapcnn/test_discover_device.py::test_is_device_type - AttributeError: module 'sinabs.backend.dynapcnn.io' has no attribute 'get_all_samna_devices'
FAILED test_dynapcnn/test_discover_device.py::test_discover_device - KeyError: 'dvxplorer:0'
FAILED test_dynapcnn/test_large_net.py::test_to_device - KeyError: 'speck2b:0'
FAILED test_dynapcnn/test_visualizer.py::test_jit_compilation - TypeError: create_visualizer_process() got an unexpected keyword argument 'visualizer_id'

For a few of them it's probably just because the correct device wasn't connected. Here we might want to consider not only testing one specific device. Others failed because of a missing get_all_samna_devices function or a wrong argument to the visualizer. Those certainly need to be fixed.

ssinhaleite commented 10 months ago

hI @bauerfe, thank you for checking the tests. Could you please create an issue with these tests and link it here? Thank you again.

bauerfe commented 10 months ago

Sure! https://github.com/synsense/sinabs/issues/204