Nonseq

[ssinhaleite]

Checklist before requesting a review

Unit tests

• [x] Tests for the changes have been added (for bug fixes/features)

• [x] All tests are passing.

  Documentation

• [ ] Add tutorial(s) about how to deploy a non-sequential model

• [ ] Fix any inconsistencies with existing documentation (e.g. changed function parameters, deprecated methods, etc.)

• [ ] Add graph that shows developers how different classes interact

• [ ] Make sure in-code documentation is complete (e.g. missing or incomplete docstrings)

• [ ] CHANGELOG.md: Make sure to list any breaking changes

  Review

• [x] I have performed a self-review of my code

• [ ] Address open suggestions from the review (typos etc)

• [ ] Take care of all TODOs inside the code

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) New feature, including extensive changes in code, documentation and unit tests.

• What is the current behavior? (You can also link to an open issue here) So far, only sequential models can be deployed on DynapCNN chips.

• What is the new behavior (if this is a feature change)? Allow non-sequential SNNs (e.g. residuals, recurrent, ...) to be deployed on DynapCNN chips.

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Potentially. Ideally for sequential SNNs there are no (or minimal) breaking changes, but this has to be assessed when reviewing this PR.

• Other information: The changes are quite extensive, so reviewing this will take some time.

[bauerfe]

I fixed a bunch of unit tests that broke during the last commits. tests/test_dynapcnnnetwork is still failing because I converted NIRtoDynapcnnNetworkGraph.edges to a set, so the order is not guaranteed anymore. I am currently handling the issue.

[bauerfe]

We will also have to see if we can still support batchnorm layers in the original SNN, and under which conditions. So far, sinabs supports that.

[bauerfe]

All unit tests passing on my machine :champagne:

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 87.16012% with 170 lines in your changes missing coverage. Please review.

Project coverage is 88.83%. Comparing base (276eda3) to head (347e225). Report is 13 commits behind head on develop.

Files with missing lines	Patch %	Lines
sinabs/backend/dynapcnn/dynapcnn_network.py	71.92%	48 Missing :warning:
sinabs/backend/dynapcnn/sinabs_edges_handler.py	90.03%	26 Missing :warning:
sinabs/backend/dynapcnn/dynapcnnnetwork_module.py	85.27%	19 Missing :warning:
sinabs/backend/dynapcnn/nir_graph_extractor.py	93.51%	17 Missing :warning:
sinabs/backend/dynapcnn/utils.py	86.02%	13 Missing :warning:
sinabs/backend/dynapcnn/dynapcnn_layer.py	87.01%	10 Missing :warning:
sinabs/backend/dynapcnn/exceptions.py	82.69%	9 Missing :warning:
sinabs/utils.py	84.21%	6 Missing :warning:
sinabs/backend/dynapcnn/dynapcnn_layer_utils.py	94.94%	5 Missing :warning:
sinabs/from_torch.py	0.00%	5 Missing :warning:
... and 4 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #245 +/- ## =========================================== - Coverage 90.91% 88.83% -2.08% =========================================== Files 52 58 +6 Lines 2718 3664 +946 =========================================== + Hits 2471 3255 +784 - Misses 247 409 +162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bauerfe]

All checks passing on the CI now (with warnings from codecov - we should probably add more unit tests eventually).

[bauerfe]

I have extended the to-do list in the original post to be more specific and complete. It should now mention everything that still needs to be addressed. Please feel free to add and tick off items when appropriate.