If you have an error on a mobile/small browser, you can't tell when there's an error

synshop / membership.synshop.org

External Membership Management System for SYN Shop

GNU General Public License v3.0

0 stars 0 forks source link

If you have an error on a mobile/small browser, you can't tell when there's an error #18

Closed mrjones-plip closed 11 months ago

mrjones-plip commented 12 months ago

When

When you're on mobile, and there's an error, it's not obvious because there's no "there's an error, please fix the red outlined field above to proceed"

See this video where I'm trying to click the "Submit" button (which is disabled, but it's still not clear)

https://github.com/synshop/membership.synshop.org/assets/8253488/22c56be3-e667-4e59-a214-ca2c4776749c

munroebot commented 12 months ago

That shouldn't be to hard to fix, let me see what I can do.

munroebot commented 12 months ago

Ok, try now? Lemme know what you think?

mrjones-plip commented 12 months ago

WAAAY BETTER! thanks!

That said, I think you need to have each field report if it's valid or something? I'm not looking at the code, but I'm still able to submit the form with invalid code. maybe a diff ticket? lemme know. I submitted with card number 222 , date 222 and cvv 222:

https://github.com/synshop/membership.synshop.org/assets/8253488/c7d06001-9df8-46b2-a7a0-b40b0142ddd6

munroebot commented 12 months ago

Ah shoot, that is a problem - let me keep poking away at this...probably have a fix tomorrow.

munroebot commented 12 months ago

btw, I feel like I'm committing some serious JS cardinal sins!

mrjones-plip commented 12 months ago

I was just testing again, even though you said you'd work on this tomorrow. I think the rules should be something like:

If there's ANY error anywhere, don't enable the "Submit" button
If there's ANY error anywhere, show the error by the "Submit" button, and the relevant fields that need fixin'
Recheck ALL fields EVERY time, don't check just the field that you're leaving/entering
Only Enable "Submit" when you have all fields green.

It's clear that the form is changing state when I enter a CVV - there's something about how the field validation works.

Again, I know you're still fixing this!

https://github.com/synshop/membership.synshop.org/assets/8253488/fc594f57-831a-4efc-9717-ea85afad9d99

mrjones-plip commented 12 months ago

I'm happy to look at the JS tomorrow or Monday night if you want some help!

munroebot commented 12 months ago

Thanks for the offer, it wasn't too bad. Give it a looksee and let me know what you think.

munroebot commented 11 months ago

Fixed