search

synshop / rtfm

SYN Shop related documentation. Pull requests welcome!
https://rtfm.synshop.org/
7 stars 12 forks source link

Update Local Resources.md. #12

Closed computercarguy closed 5 years ago

computercarguy commented 5 years ago

Added more information for more local businesses in the Plastics section.

mrjones-plip commented 5 years ago

Thanks for the two PRs! Lemme review them over the weekend and let's get them merged! We really appreciate you taking the time to make our docs better. Sorry for the delay!

computercarguy commented 5 years ago

I'm glad that I was able to help. I've spent a considerable amount of time and energy looking for acrylic for myself, and if it help others, that's even better.

I might have another addition for Piedmont Plastics, but I haven't contacted them yet, so don't hold up your reviews on that account.

Eric Ingamells

On Fri, Dec 21, 2018 at 10:11 PM Ths2-9Y-LqJt6 notifications@github.com wrote:

Thanks for the two PRs! Lemme review them over the weekend and let's get them merged! We really appreciate you taking the time to make our docs better. Sorry for the delay!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/synshop/rtfm/pull/12#issuecomment-449548303, or mute the thread https://github.com/notifications/unsubscribe-auth/ABw-ovA4ljl-s2zQrdRKwg8O3Gq6Y_Beks5u7c0KgaJpZM4ZXeKh .

mrjones-plip commented 5 years ago

Eric - I took a look and while all the information is great, some of the formatting is off. If you take a look at the current page you'll see that each address, city/state/zip and phone area all on their own lines. Could you update your changes to match this formatting?

lemme know if you need a hand!

computercarguy commented 5 years ago

I fixed the formatting issues. The MarkDown editor I used evidently uses a different standard to display the files.

Also, the MD editor at https://jbt.github.io/markdown-editor/ is extremely user unfriendly. Everything seems to be highlighted, the preview pane scrolls to a different section than you are editing, and the file editor is even worse, since you have to "flip" between writing and preview.

That's nothing you control, but I started programming so I could make things easier, not harder. Evidently my idea of "easier" is completely different than other programmers.

mrjones-plip commented 5 years ago

Looks great! If you're not already, I strongly recommend installing mkdocs. When you do, you can just run mkdocs serve and you'll see exactly what the code will look like on rtfm - the web page even reloads when you make any changes!