synshop / rtfm

SYN Shop related documentation. Pull requests welcome!
https://rtfm.synshop.org/
7 stars 12 forks source link

Consew 230 Industrial Sewing Machine Documentation #14

Closed ItinerantEngineer closed 5 years ago

ItinerantEngineer commented 5 years ago

Excuse the excessive commit count, was testing SlackEdit.io and its syncing was a bit ridiculous.

mrjones-plip commented 5 years ago

Heh - no worries about the excessive commits ;)

The content is great and a welcome addition - thank you!

The only change is that the images appear to be the raw size from your phone, thus are too big for the web page. Each one is multiple megs, when they should be no larger than about 300k. The easiest way to reduce their size is to make them smaller. I'd say about 1000px on the largest size? You could try smaller if you wanted. The goal would be to get it as small as possible in disk/download size but not lose the any details - specifically where the the thread interfaces with each part of the machine.

Thanks again and let me know if you need a hand on the resizing!

ItinerantEngineer commented 5 years ago

Hmm, when I served the pages locally on MkDocs they seemed to resize into the page, and I left them big in case it's auto resizing needed a minimum resolution. Busy at the shop today, but I can look up what minimum resolution it needs later, or if your know offhand feel free to resize!

On Sat, Dec 22, 2018, 4:38 PM Ths2-9Y-LqJt6 <notifications@github.com wrote:

Heh - no worries about the excessive commits ;)

The content is great and a welcome addition - thank you!

The only change is that the images appear to be the raw size from your phone, thus are too big for the web page. Each one is multiple megs, when they should be no larger than about 300k. The easiest way to reduce their size is to make them smaller. I'd say about 1000px on the largest size? You could try smaller if you wanted. The goal would be to get it as small as possible in disk/download size but not loose the any details - specifically where the the thread interfaces with each part of the machine.

Thanks again and let me know if you need a hand on the resizing!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/synshop/rtfm/pull/14#issuecomment-449606393, or mute the thread https://github.com/notifications/unsubscribe-auth/Aodt2pWmT0kW_893kVTXnt-h39B9wTPjks5u7tCSgaJpZM4Zfi3J .

mrjones-plip commented 5 years ago

Right - the images look great on the page! However, for folks on slower connections, these could possibly take a long time to download - that's my concern. Thanks again!

ItinerantEngineer commented 5 years ago

Updated!

mrjones-plip commented 5 years ago

Awesome - thanks a bunch - Merging!