search

syntagmatic / parallel-coordinates

A d3-based parallel coordinates plot in canvas. This library is no longer actively developed.
http://syntagmatic.github.com/parallel-coordinates/
Other
511 stars 211 forks source link

console now displaying message about multi-brush #101

Closed mg1075 closed 9 years ago

mg1075 commented 9 years ago

Is it really necessary to have the console show a message about d3.multibrush, even if it is not going to be used?

https://github.com/syntagmatic/parallel-coordinates/blob/d30801e386db33f8c54ab68af77344e82cc67e65/d3.parcoords.js#L1233-L1237

  if (typeof d3.svg.multibrush !== 'function') {
      console.log("multibrush requires d3.svg.multibrush");
      return;
  }
julianheinrich commented 9 years ago

Not really. I wanted to discuss how to include multibrush anyway. As submodule, library, or just adding it to the code base?

On Fri, 1 May 2015 17:55 mg1075 notifications@github.com wrote:

Is it really necessary to have the console show a message about d3.multibrush, even if it is not going to be used?

https://github.com/syntagmatic/parallel-coordinates/blob/d30801e386db33f8c54ab68af77344e82cc67e65/d3.parcoords.js#L1233-L1237

if (typeof d3.svg.multibrush !== 'function') { console.log("multibrush requires d3.svg.multibrush"); return; }

— Reply to this email directly or view it on GitHub https://github.com/syntagmatic/parallel-coordinates/issues/101.