search

syntagmatic / parallel-coordinates

A d3-based parallel coordinates plot in canvas. This library is no longer actively developed.
http://syntagmatic.github.com/parallel-coordinates/
Other
511 stars 211 forks source link

Packages Fix #285

Closed dehli closed 8 years ago

dehli commented 8 years ago

Good evening,

With one of the recent pushes, npm install and bower install were broken. With bower, it's referencing packages that aren't part of the bower registry. With npm, frontend packages were included as dependencies in package.json. This would be fine, however all the required packages aren't available in the npm registry (d3.svg.multibrush isn't available through the npm registry, and sylvester doesn't have the correct version). Since this package itself isn't in the npm registry I propose that we keep the frontend packages only in bower.

This changeset fixes those issues. Additionally I pulled out the libraries that are provided via bower (so that the library is always using the proper versions referenced in bower.json).

Whenever code is pushed to the gh-pages branch, you'll want to make sure that you include the bower_components (or at least the few files from this folder that are required). This can easily be accomplished by modifying the .gitignore file on the gh-pages branch so that it has the following lines appended:

!bower_components/d3/d3.min.js
!bower_components/d3.svg.multibrush/d3.svg.multibrush.js
!bower_components/sylvester/sylvester.js
!bower_components/underscore/underscore.js
!bower_components/underscore.math/underscore.math.js

The reason I bumped the d3 requirement to 3.5 is because d3.svg.multibrush v0.9.1 (which this library depends on) has 3.5 as its minimum version.

I also updated the package, so that executing npm start will automatically take care of all the steps needed to install the required packages, and start an http-server hosting the contents of the repository. These changes are found in package.json.

Thanks, and let me know if you have any questions about this change.

BroHammie commented 8 years ago

Thanks @dehli! I should have tested the changes I made to the package files. My goal was to document external dependencies the library had that were not easily noticeable.

I am in favor of adding the http-server dependency and the scripts you added.

I think that the change to require developers to use bower to download the libraries for the examples should be left out. @syntagmatic has been apprehensive towards bower and we should probably only use bower.json for configuring bower and not development of parallel-coordinates.

dehli commented 8 years ago

Okay! That's understandable. I will close this one and open a new pull request because it would be easier than going through and reverting the individual changes.

On second thought, I'll just locally revert the change and then push to my own master so I can just use this pull request.