Closed dehli closed 8 years ago
It looks like the canvas for the screenshot needs to pull in the scale factor for retina displays. On a rMPB the SVG looks good, but the canvas ends up at a different size. https://github.com/syntagmatic/parallel-coordinates/pull/288
Thanks @syntagmatic! I forgot to account for retina displays. I'll make a fix for it.
Hi @syntagmatic, I believe I fixed the issue. I don't have a retina display to test it but I tested it by using the zoom feature in the browser. Let me know what you think!
Hey @syntagmatic, would it be okay with you if I went ahead and merged this PR?
Sorry I was on vacation! Let me do a quick test this evening on my macbook, just to check.
No worries! @syntagmatic I wasn't sure if you had forgotten about this. Hope you had a good vacation!
Works for me! Nice job!
For this function, I made a few changes.
mergeParcoords
function which merges the canvases and the SVG elements together into one canvas.canvas
element can be used by the consumer in whatever way they want. I added adownload
example which shows how it can be used to download a screenshot of the chart.Let me know your thoughts. Thanks!
Notes:
SecurityError
whenever I try to save the contents of the merged canvas). This is the main reason why I chose to have the function return a canvas instead of just saving the screenshot.