Brush extents fire events fix

syntagmatic / parallel-coordinates

A d3-based parallel coordinates plot in canvas. This library is no longer actively developed.

http://syntagmatic.github.com/parallel-coordinates/

Other

511 stars 212 forks source link

Brush extents fire events fix #338

Open Git-me-outta-here opened 7 years ago

Git-me-outta-here commented 7 years ago

brushExtents now fires events only after all new extents have been set. This prevents calls to 'brushend' with incomplete brushings.

Example: brushExtents updates extent on dimension 1, calls 'brushend' with wrong .brushed b/c dimension 2 does not have a brush extent yet; then updates extent on dimension 2, calls 'brushend' again, this time with correct .brushed

Git-me-outta-here commented 7 years ago

I guess this could be improved. In fact this should only send a single event, not one per dimension.