search

syntagmatic / parallel-coordinates

A d3-based parallel coordinates plot in canvas. This library is no longer actively developed.
http://syntagmatic.github.com/parallel-coordinates/
Other
510 stars 211 forks source link

Render function in non-progressive mode does not clear highlight canvas #86

Open shodanjr opened 9 years ago

shodanjr commented 9 years ago

I came across this when setting some highlights on the graph externally then proceeding to manipulate the axes via re-ordering. The highlight canvas is not cleared but the highlights themselves are redrawn in the render['default'] function. Consequently something that should look like this:

screen shot 2015-01-31 at 12 28 36 am

ends up looking like this:

screen shot 2015-01-31 at 12 28 20 am

after moving the axes around a few times.

The pc.render['default'] function seems to be missing a call to pc.clear('highlight'), similar to the queue-based rendering function.

bbroeksema commented 9 years ago

If you can submit a pull request with the required fix, I'll merge it. If I need to investigate this, you'll have to wait a bit.

shodanjr commented 9 years ago

See above for the PR. It's literally a one-line fix. I wasn't able to get the test-suite going for some reason on my machine though so caveat emptor :).