search

syntasso / helm-charts

Helm charts for Kratix
Apache License 2.0
0 stars 2 forks source link

enhancement: ske-operator helm chart should wait for ske-operator to be ready to create ske deployment #6

Open ChunyiLyu opened 1 month ago

ChunyiLyu commented 1 month ago

Context

We don't have any logic to wait for ske-operator deployment become ready before create kratix deployment, which could lead to failure such as:

"syntasso" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "syntasso" chart repository
Update Complete. ⎈Happy Helming!⎈
Error: INSTALLATION FAILED: failed to create resource: Internal error occurred: failed calling webhook "vkratix.kb.io": failed to call webhook: Post "https://ske-operator-webhook-service.kratix-platform-system.svc:443/validate-platform-syntasso-io-v1alpha1-kratix?timeout=10s": no endpoints available for service "ske-operator-webhook-service"

This happens rarely but it's not a nice experience. Perhaps we can leverage chart hooks to improve this: https://helm.sh/docs/topics/charts_hooks/

Phiph commented 1 week ago

Could you use something like a HealthCheck - or something else?

From my experience - when using helm charts with Hooks, they don't work well when using them Kratix.

I had a helm chart that I wanted to create a Promise with, but as it renders out the helm chart I found that the hooks didn't kick in.