syntasso / kratix-docs

1 stars 8 forks source link

fix(vault pipeline): check for secrets in `/kratix/output/` instead of `/kratix/input` #60

Closed kirederik closed 1 month ago

kirederik commented 1 month ago

similar to the snyk/trivy image (see #59), the vault image was built on old assumptions;

however, different than those other ones, it's pretty much useless right now, since a Secret will never exist in the /kratix/input directory; this story is to fix that so people can actually use the image

also, similar to #57 , the vault image needs access to a configmap, and the current implementation relies on a configmap existing with a known name. a better approach would be to use volumeMounts and read it from the local filesystem.

Tasks

kirederik commented 1 month ago

PR: https://github.com/syntasso/kratix-marketplace/pull/7