search

syntasso / kratix-marketplace

Apache License 2.0
10 stars 8 forks source link

API Kinds must be in UpperCamelCase in a resource-request.yaml #11

Open yuriylesyuk opened 4 months ago

yuriylesyuk commented 4 months ago

The resource-request.yaml is a Kubernetes manifest, but the API kind field values for apiVersion: marketplace.kratix.io/v1alpha1 are de facto in a snake-case.

That's a bit unexpected. Being a Kubernetes manifest, I would expect the kind field value to be UpperCamelCase. Any particular reason why it is not?

kirederik commented 4 months ago

hey @yuriylesyuk

thanks for the feedback!

do you mean the underlying kind provided by the marketplace promises? if so, i guess it was something we overlook when creating the promises, as you are right, UpperCamelCase would be more consistent with other kubernetes resources.

i'll take a look into updating them