syntasso / kratix

Kratix is an open-source framework for building platforms
https://kratix.io
Apache License 2.0
423 stars 23 forks source link

feat: make git author configurable in the GitStateStore #147

Closed richcooper95 closed 2 weeks ago

richcooper95 commented 1 month ago

Currently, we always use the Kratix service account in our Git commits. We should instead make this configurable.

Image

Details

mrdavidlaing commented 1 month ago

Having a static GitAuthor would be great.

Not sure if this is possible; but even better would be a dynamic GitAuthor based on the identity that modified the promise resource-request.

ie - if user alice@my-corp.com ran kubectl apply -f my-promise-request.yaml then the commit to the GitStateStore would be attributed to alice@my-corp.com

That way commits to the GitStateStore become an audit log of who made which changes to the system without needing to enforce changes to the system going through a PR workflow that runs kubectl apply -f my-promise-request.yaml

aclevername commented 3 weeks ago

@mrdavidlaing

Having a static GitAuthor would be great.

We've just merged this feature #161

ie - if user alice@my-corp.com ran kubectl apply -f my-promise-request.yaml then the commit to the GitStateStore would be attributed to alice@my-corp.com That way commits to the GitStateStore become an audit log of who made which changes to the system without needing to enforce changes to the system going through a PR workflow that runs kubectl apply -f my-promise-request.yaml

Thats a great idea. Going to leave this issue open to track (cc @catmo-syntasso )

kirederik commented 2 weeks ago

we created https://github.com/syntasso/kratix/issues/162 to capture the request; we'll now really close this one