Closed richcooper95 closed 2 weeks ago
Having a static GitAuthor
would be great.
Not sure if this is possible; but even better would be a dynamic GitAuthor
based on the identity that modified the promise resource-request.
ie - if user alice@my-corp.com
ran kubectl apply -f my-promise-request.yaml
then the commit to the GitStateStore would be attributed to alice@my-corp.com
That way commits to the GitStateStore become an audit log of who made which changes to the system without needing to enforce changes to the system going through a PR workflow that runs kubectl apply -f my-promise-request.yaml
@mrdavidlaing
Having a static GitAuthor would be great.
We've just merged this feature #161
ie - if user alice@my-corp.com ran kubectl apply -f my-promise-request.yaml then the commit to the GitStateStore would be attributed to alice@my-corp.com That way commits to the GitStateStore become an audit log of who made which changes to the system without needing to enforce changes to the system going through a PR workflow that runs kubectl apply -f my-promise-request.yaml
Thats a great idea. Going to leave this issue open to track (cc @catmo-syntasso )
we created https://github.com/syntasso/kratix/issues/162 to capture the request; we'll now really close this one
Currently, we always use the Kratix service account in our Git commits. We should instead make this configurable.
Details
GitAuthor
struct and add it to theGitStateStoreSpec
.git.go
here if it's present, and default to the Kratix service account if not.