syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build
https://spot.sites.ucsc.edu/
GNU General Public License v2.0
12 stars 2 forks source link

Major minor phrases #419

Closed ColinAChen closed 4 years ago

ColinAChen commented 4 years ago

close #263

ColinAChen commented 4 years ago

image I think the code for this warning may need to be changed to look at the new PH_PHI constant pCat because pCat may get overwritten with a custom pCat.

jbellik commented 4 years ago

Yes, and it should really say "[category] is not in the currently specified prosodic hierarchy. See PH_PHI and PHI_MAJMIN in prosodicHierarchy.js for some possible predefined prosodic hierarchies."

Ideally this error would actually also display the current pCat.

jbellik commented 4 years ago

Just tried this out and I think we need that warning "category argument phi is not in pCat" to be an error, actually. Right now it's displaying once for every candidate, I believe, and instead we should be quitting as soon as the first mismatch is discovered. That error should also provide some more information by displaying the current pCat.