search

syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build
https://spot.sites.ucsc.edu/
GNU General Public License v2.0
12 stars 2 forks source link

Save/load strings #474

Closed maxTarlov closed 3 years ago

maxTarlov commented 3 years ago

saving and loading automatic string generation. there is still some testing to be done, but it appears to be working fine. closes #416

maxTarlov commented 3 years ago

I am having trouble getting the automated testing to work, but manually testing the functionality has revealed no issues to me. @jbellik do you want to start code review or would you prefer me to figure out the automated testing first?

(I think the automated testing issue has to do with loading in the libraries from an external source. If we were willing to include the dependencies in the repository, I might be able to get it to work better.)

jbellik commented 3 years ago

How about you try adding the dependencies to the repo -- you can put them in the lib folder -- and if that doesn't fix it, then I'll go ahead and review your code with manual testing? We can come back to the automated testing later if need be.

On Mon, Oct 12, 2020 at 10:45 AM Max Tarlov notifications@github.com wrote:

I am having trouble getting the automated testing to work, but manually testing the functionality has revealed no issues to me. @jbellik https://github.com/jbellik do you want to start code review or would you prefer me to figure out the automated testing first?

(I think the automated testing issue has to do with loading in the libraries from an external source. If we were willing to include the dependencies in the repository, I might be able to get it to work better.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/syntax-prosody-ot/main/pull/474#issuecomment-707259304, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7ROKSUU6SUEVJ3LCNUJNTSKM6ERANCNFSM4SFVYKZA .

--

-- Jennifer Bellik, PhD Post-doctoral researcher & lecturer UC Santa Cruz https://people.ucsc.edu/~jbellik/

maxTarlov commented 3 years ago

So the unit tests are working and the "addThickLine" css error that we had seen in the meeting last week is fixed. One small issue is that "load with two strings" raises an error because the min and max inputs are not integers. I am not quite sure what to do about that, but interestingly mocha shows the test as running twice and passing the second time. I think this is ready for review, since the integer thing isn't crucial, but I can try to figure something out before we merge

maxTarlov commented 3 years ago

I fixed the error by changing the arbitrary strings to really large integers. We avoid making thousands of permutations by setting min and max to really close integers (e.g. 9001, 9002). With these really big integers, the maximum call stack error goes away, but no permutations are actually displayed. I am not sure if this is a display problem or if the strings just aren't being generated, but strings are definitely being generated with smaller integers, so I am not really worried. (The large integers we probably won't find anywhere else in the analysis, making the saving test more likely to catch unsaved inputs.)

R.e. why only two-string inputs raise an error, it does not have to do with the loading mechanics (I checked manually that the "generate terminal strings" button is being clicked on both one- and two-string analyses). If I had to guess, I would say that the error is being thrown in both instances, but it is being caught only when there is just one string. I have opened issue #491 to continue the conversation about string generation inputs and error handling.