search

syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build
https://spot.sites.ucsc.edu/
GNU General Public License v2.0
12 stars 2 forks source link

input 6 terminals #511

Closed sz245 closed 3 years ago

sz245 commented 3 years ago

Inputs of more than 6 terminals warning show only once

sz245 commented 3 years ago

I am kind of confused by 'we do want one warning every time "Get results" is clicked' because in the issue, it said "would be better to only show it once, so users with several long inputs only have to click "continue" once." Could you elaborate more on that part?

jbellik commented 3 years ago

Yes: if the user provides 5 problematic inputs and clicks "Get results", the implementation I reviewed would give one warning the first time. (Good.) Then if the user provides another problematic set of inputs and clicks "Get results" again, it gives zero warning. (Bad.) This is a problem because there should still be one warning.

In the master branch, if the user provides 6 problematic inputs and clicks "Get results", they will get 6 warnings. That's bad too, because it would be better to just have one warning -- which is the original motivation for this issue.

Does that clarify? Rather than getting one warning per problematic input (current master branch behavior), we want one warning per click of "Get results" (if there are problematic inputs; too many warnings). Also, rather than getting one warning per page load (behavior of this branch last I checked; not enough warnings), we want one warning per click of "Get results" (again, if there are problematic inputs).

sz245 commented 3 years ago

That does clarify it. Thank you.

jbellik commented 3 years ago

Ok, great.

On Mon, Nov 30, 2020 at 3:40 PM M130 notifications@github.com wrote:

That does clarify it. Thank you.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/syntax-prosody-ot/main/pull/511#issuecomment-736120897, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7ROKXD3JGHUFAVPOA2AOLSSQUNPANCNFSM4UAJECWA .

--

-- Jennifer Bellik, PhD Post-doctoral researcher & lecturer UC Santa Cruz https://people.ucsc.edu/~jbellik/