syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build
https://spot.sites.ucsc.edu/
GNU General Public License v2.0
12 stars 2 forks source link

Deleting terminals from trees in manual tree builder #513

Closed jbellik closed 3 years ago

jbellik commented 3 years ago

If multiple terminals are selected in the tree builder and the user clicks "Delete", an error complains that the selected nodes don't share a mother, even if they actually do. Either the conditions under which this error appears, or the wording of the error, should be corrected.

jbellik commented 3 years ago

Minimal version: Change wording of error to be very general. "Please delete only one node at a time." Better version: Make it possible to delete multiple nodes, as long as they have the same mother.

jbellik commented 3 years ago

Don't worry about trying to delete mother + child at the same time.

jbellik commented 3 years ago

Relevant code is in main/interface/interface_treebuilder.js specifically function deleteTreeUINodes() on line 348