Closed jbellik closed 3 years ago
Create Mocha tests for this too. If the syntactic tree (inputTree) only contains nodes of cat: 'xp' and cat: 'cp', then: matchSP(inputTree, ptree, any) = matchSP(inputTree, ptree, 'xp') + matchSP(inputTree, ptree, 'cp')
On the interface, make MatchSP-any look visually consistent with StrongStart-global and StrongStart-local (under Markedness > Sisterhood).
For (1), you need to adjust the conditions in lines 95-96 of tableauMaker.js. Also check how categories are handled for strongStart_Elfner.
See test/manual_testing/matchOptions.html as an example of a file that is broken currently & should not be.
matchSP(inputTree, ptree, any) = /= matchSP(inputTree, ptree, 'xp') + matchSP(inputTree, ptree, 'cp') when testing. matchSP(inputTree, ptree, any) also seems to be counting things categorized as "x0" or "c0" etc. Is that right or does it need to be corrected?
Check if Match-any is broken due to the checking of the prosodic hierarchy. Error checking in makeTableau() probably needs to be made more nuanced to only check that the category is in pCat if it's not "any" or "". Two other possible ways to handle this are (1) to change the way we refer to the category in category-insensitive Match to just not specify a category at all, or (2) change the category-check to just create a warning rather than throwing an error.
Add interface support for "Match-any" (Match that ignores syntactic categories) by adding a checkbox with value 'any'.