Permutation Bugfix - Githubissues

syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build

https://spot.sites.ucsc.edu/

GNU General Public License v2.0

12 stars 2 forks source link

Permutation Bugfix #561

Closed 3ddiehead closed 3 years ago

3ddiehead commented 3 years ago

Just needed to split the "words" string on " ". Before this, every char in the string was used for permutation.

jbellik commented 3 years ago

Closes #554

jbellik commented 3 years ago

Add a comment to make it clear what we're using
Prioritize words if both arguments are provided (for the sake of consistency with GEN)
If stree has leaves and words was also provided and the length doesn't match, then give a warning. Use displayWarning() which can handle being called either in or out of the interface.
Check that it's still working on the interface after this.

Feel free to refactor this function to pull out the permutation generator from the tree generating part.