Fixed Issue, small fix, lots of exploration

syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build

https://spot.sites.ucsc.edu/

GNU General Public License v2.0

12 stars 2 forks source link

Fixed Issue, small fix, lots of exploration #575

Closed 3ddiehead closed 3 years ago

3ddiehead commented 3 years ago

Bug fixed by passing the showHeads option into a valueless variable used to decide whether or not to call markHeads().

markHeads now flags trees after they are marked. The function only runs if the tree hasn't been touched by it before.

BinMaxHead is already connected with the GEN: Output parameters' Tree marking options but I have added info to the BinMaxHead infobox to indicate this.

I could not recreate the bug in the issue, but there was still a bug.

jbellik commented 3 years ago

When "mark prosodic heads" gets auto-checked by selection of BinMaxHead, then expand the "Tree marking options" fieldset as well.
If BinMaxHead is selected and "mark prosodic heads" hadn't already been selected, then displayWarning("You selected BinMaxHead. By default, heads will be marked on the right.")
add a tableau to the html test file for visual inspection

jbellik commented 3 years ago

This is looking good. One thing I noticed though is that there aren't any tests for setting side: "left". Please add one so we have something auto-checking that we haven't broken that feature. Then I think this will be done!