search

syntax-prosody-ot / main

A webapp for the syntax-prosody analyst working in Optimality Theory, with automated Gen, Con and Eval. Download build files from syntax-prosody-ot/build
https://spot.sites.ucsc.edu/
GNU General Public License v2.0
12 stars 2 forks source link

Gen recursive cats representation #598

Open jbellik opened 3 years ago

jbellik commented 3 years ago

Currently Gen with multiple recursive categories supports either separating them with hyphens ('phi-w'), or inputting them as an array, e.g., ['phi', 'w'].

Let's switch over entirely to using the array representation. Testing is already using the array representation, but the interface is using the string representation.

3ddiehead commented 2 years ago

Numerous failures now exists among the various mocha tests. For example: -- Failures in GENargumentTests GENargumentTestsErr

-- Failures in GENinputTest doubleWrappingErr

Other failures in GENoutputTest and compound_w_gen

jbellik commented 2 years ago

Bother, I may have caused those yesterday when I tried to make obeysHeadedness: true the default setting for Gen.

jbellik commented 2 years ago

Are these tests failing on your local branch? If so, try updating from master because they are all passing on master now.

3ddiehead commented 2 years ago

I fixed the failures except on GENinputTest by making a copy of options in GEN instead of referencing the variables assigned a set of options in compound_w_GEN

3ddiehead commented 2 years ago

The issue with GENinputTest was originally that nodes would receive the category ['xp'] instead of 'xp'. I fixed this by making sure the default category was (ironically) ['xp'] instead of 'xp'. Now the issue has to do with the naming of node ID's when sTreeGEN() is run. The tree output is all correct and every node has a unique ID, but the first node is not 'xp0' it is 'xp2'.

3ddiehead commented 2 years ago

We can manually change the tests to test for parenthesized trees, but that wouldn't help to understand why ID-ing is non-standard in sTreeGEN().