syntax-tree / hast-util-sanitize

utility to sanitize hast nodes
https://unifiedjs.com
MIT License
48 stars 20 forks source link

GFM footnotes #30

Closed ngnhat closed 8 months ago

ngnhat commented 8 months ago

Initial checklist

Affected packages and versions

"rehype-sanitize": "^6.0.0"

Link to runnable example

react-markdown

Steps to reproduce

the rehype-sanitize has changed the id of the elements below:

<a href="#user-content-fn-1" id="user-content-user-content-fnref-1" data-footnote-ref="true" aria-describedby="user-content-footnote-label">1</a>

...

<li id="user-content-user-content-fn-1">
<p>something...  <a href="#user-content-fnref-1" data-footnote-backref="" aria-label="Back to reference 1" class="data-footnote-backref">↩</a></p>
</li>

Expected behavior

It should not be changed.

Actual behavior

idk

Affected runtime and version

node@18.2

Affected package manager and version

No response

Affected OS and version

No response

Build and bundle tools

No response

ChristianMurphy commented 8 months ago

Duplicate of https://github.com/syntax-tree/hast-util-sanitize/issues/29

github-actions[bot] commented 8 months ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

github-actions[bot] commented 8 months ago

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks, — bb