syntax-tree / mdast-util-directive

mdast extension to parse and serialize generic directives (`:cite[smith04]`)
https://unifiedjs.com
MIT License
12 stars 6 forks source link

Fix types #8

Closed difanta closed 1 year ago

difanta commented 1 year ago

Initial checklist

Description of changes

Added a type import that was causing problems with using this library: namely mdast nodes didn't inherit from Mdast.Parent but from a non typed version of it Parent=any. This was causing type checks to fail on properties like node.data. I apologize in advance if i was not understanding the issue fully before making any changes, as this is my first contribution, but this small fix is what i found to be the problem, cheers and have a good day.

github-actions[bot] commented 1 year ago

Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.

You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done!

If you need it, here’s the original template ```markdown ### Initial checklist * [ ] I read the support docs * [ ] I read the contributing guide * [ ] I agree to follow the code of conduct * [ ] I searched issues and couldn’t find anything (or linked relevant results below) * [ ] If applicable, I’ve added docs and tests ### Description of changes TODO ```

Thanks, — bb

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

wooorm commented 1 year ago

Thank you, released in 2.2.4!