Test for escaping of HTML chars in table

SamyPesse commented 3 years ago

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Hello 👋

I'm investigating an issue where the formatting to markdown doesn't escape HTML chars in a table cell.

I'm still new to contribute to remark/mdast/etc, this PR is only started with a failing test till I deep dive more into the issue.

For example, considering the following table:

| A | B |
| :--- | :--- |
| C | &lt;D E&gt; |

it's parsed as the following table cell:

{
    "type": "tableCell",
    "children": [
        {
            "type": "text",
            "value": "<D E>"
        }
    ],
    ...
}

which then using remark-stringily (and this module under it), output:

| A | B |
| :--- | :--- |
| C | <D E> |

💥 which crash at parsing because <D E> is not recognised as HTML.

wooorm commented 3 years ago

Hi Samy!

wooorm commented 3 years ago

Think the problem is that table cells aren’t marked as phrasing, and so non of the escapes for that construct work: https://github.com/syntax-tree/mdast-util-to-markdown/blob/main/lib/unsafe.js

github-actions[bot] commented 3 years ago

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

wooorm commented 3 years ago

SamyPesse commented 3 years ago

Thank you @wooorm 🙌

syntax-tree / mdast-util-gfm-table